fabrics: add additional error messages for --concat#3063
Merged
igaw merged 3 commits intolinux-nvme:masterfrom Jan 16, 2026
Merged
fabrics: add additional error messages for --concat#3063igaw merged 3 commits intolinux-nvme:masterfrom
igaw merged 3 commits intolinux-nvme:masterfrom
Conversation
--tls and --concat are mutually exclusive and not meant to be invoked together. So add an appropriate error message for the same. Signed-off-by: Martin George <[email protected]>
--concat requires a corresponding dhchap-secret key to be passed with it. So add an appropriate error message if this is not done. Signed-off-by: Martin George <[email protected]>
--concat works only with unidirectional auth and not bidirectional auth. As per section 8.3.4.5.9 Generated PSK for TLS in the NVMe base spec 2.1: "The host may request secure channel concatenation with the TLS protocol by setting the SC_C field in the AUTH_Negotiate message to NEWTLSPSK while performing only unidirectional auth. In this case, the host shall send a challenge value C2 to the controller and clear the sequence number S2 to 0h to indicate that controller authentication is not requested". In the kernel too, if both host and controller auth keys are specified with secure channel concat, it would ignore the controller key and and default to using the host key itself for uni-auth with concat TLS. So add an appropriate error to catch the same in the userspace itself. Signed-off-by: Martin George <[email protected]>
Collaborator
|
Thanks a lot. We should also update the documentation with this information. When the kernel eventually also supports to access the dhchap keys from the kernel keystore, we should update the error messages. But that's for another day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secure channel concat TLS has some specific prerequisites and conditions. So add appropriate error messages for each of these.